Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: 96 files have "the the" typo #20682

Closed
ohbarye opened this issue May 11, 2018 · 3 comments
Closed

doc: 96 files have "the the" typo #20682

ohbarye opened this issue May 11, 2018 · 3 comments

Comments

@ohbarye
Copy link
Contributor

ohbarye commented May 11, 2018

  • Version: None
  • Platform: None
  • Subsystem: None

There are 96 files including a common typo of "the the" in this repository, to be precise, in deps, doc, and tools directory. I assume some of them are 3rd party's and no need to revise, but is there anything that needs to be fixed?

$ ag  'the the' -l | wc -l
96

$ ag  'the the' -l | sed "s/^\([^/]*\).*/\1/" | uniq
deps
doc
tools
Full output
deps/cares/include/ares_rules.h:86: * ares_socklen_t is actually the the same as the one reported
deps/gtest/src/gtest.cc:1750:// The following two functions only make sense if the the system
deps/icu-small/source/common/dictbe.cpp:529:        // next word. If it's not a dictionary word, we will combine it withe the word we
deps/icu-small/source/common/dictbe.cpp:722:        // next word. If it's not a dictionary word, we will combine it withe the word we
deps/icu-small/source/common/rbbiscan.cpp:998:    //      - an advance to the the next input char
deps/icu-small/source/common/rbbisetb.h:46:    UVector           *fIncludesSets;   // vector of the the original
deps/icu-small/source/common/uprops.h:245: * Get the the maximum values for some enum/int properties.
deps/icu-small/source/common/utrie.cpp:718: * the then even larger BMP index length even for empty tries.
deps/icu-small/source/i18n/collationbuilder.h:354:     * then addRelation(secondary) would skip forward to the the COMMON_WEIGHT16 node.)
deps/icu-small/source/i18n/csrecog.h:46:     * Return TRUE if the the input bytes are a potential match, and
deps/icu-small/source/i18n/decimfmt.cpp:1514:                    // length, else it can be <= the the secondary group
deps/icu-small/source/i18n/hebrwcal.cpp:439:* Returns the the type of a given year.
deps/icu-small/source/i18n/rbt_rule.cpp:53: * @param anchorStart TRUE if the the rule is anchored on the left to
deps/icu-small/source/i18n/rbt_rule.h:175:     * @param anchorStart    TRUE if the the rule is anchored on the left to
deps/icu-small/source/i18n/regexcmp.cpp:170:    //      - an advance to the the next pattern char
deps/icu-small/source/i18n/reldtfmt.h:202:     * Get the date pattern for the the date formatter associated with this object.
deps/icu-small/source/i18n/reldtfmt.h:210:     * Get the time pattern for the the time formatter associated with this object.
deps/icu-small/source/i18n/unicode/decimfmt.h:1284:     * @param newValue    the new value of the the positive prefix to be set.
deps/icu-small/source/i18n/unicode/decimfmt.h:1303:     * @param newValue    the new value of the the negative prefix to be set.
deps/icu-small/source/i18n/unicode/fmtable.h:573:     * Sets the the numeric value from a decimal number string, and changes
deps/icu-small/source/i18n/unicode/format.h:85: * something illformed about the the Unicode replacement character
deps/icu-small/source/i18n/unicode/ucal.h:1422: * If the target time is after the current calendar setting, the the returned value will be positive.
deps/icu-small/source/i18n/unicode/ulocdata.h:142: * @param uld       Pointer to the The locale data object to set.
deps/icu-small/source/i18n/usearch.cpp:1100:* @return TRUE if the the match is repeated, FALSE otherwise
deps/icu-small/source/i18n/usearch.cpp:1140:    // intricacies of the the backwards collation element iterator
deps/npm/CHANGELOG.md:670:  never being installed deeper than the the thing it relies on.  At the moment
deps/npm/changelogs/CHANGELOG-2.md:4107:  Rescue one of the the disabled tests and make it work properly.
deps/npm/changelogs/CHANGELOG-3.md:4012:  headers. When this metadata included cycles, it resulted in the the tar
deps/openssl/openssl/Configurations/README:423:Configure places no rules on the command line, except the the first
deps/openssl/openssl/crypto/aes/asm/aesv8-armx.pl:23:# are literally equal to the theoretical estimates based on AES
deps/openssl/openssl/crypto/aes/asm/aesni-x86_64.pl:64:# disjointly. Parallelizable modes practically achieve the theoretical
deps/openssl/openssl/CHANGES:9312:  *) Added more prefixes to parse for in the the strings written
deps/openssl/openssl/CHANGES:11057:  *) Add support for the the free Netwide assembler (NASM) under Win32,
deps/openssl/openssl/crypto/des/asm/des_enc.m4:119:! After the the original LibDES initial permutation, the resulting left
deps/openssl/openssl/crypto/des/asm/des_enc.m4:536:!  left and right ends up the the registers originally used.
deps/openssl/openssl/crypto/ec/ec_asn1.c:574:         * use the asn1 OID to describe the the elliptic curve parameters
deps/openssl/openssl/doc/ssl/SSL_SESSION_set1_id.pod:24:SSL_SESSION_set1_id() sets the the session ID for the B<ssl> SSL/TLS session
deps/openssl/openssl/include/openssl/ec.h:353:/** Creates an ECPARAMETERS object for the the given EC_GROUP object.
deps/openssl/openssl/include/openssl/ec.h:369:/** Creates an ECPKPARAMETERS object for the the given EC_GROUP object.
deps/openssl/openssl/ssl/record/rec_layer_s3.c:364:     * than the the original len from a write which didn't complete for
deps/openssl/openssl/ssl/s3_cbc.c:421:             * If this the the block containing the end of the application
deps/openssl/openssl/ssl/ssl_ciph.c:1392:    /* RC4 is sort-of broken -- move the the end */
deps/openssl/openssl/ssl/ssl_locl.h:1318: * header as well as the the handshake message header.
deps/openssl/openssl/test/ssl-tests/13-fragmentation.conf.in:107:    # around 4. Since the the test buffer is 64kB, a 4kB fragment is
deps/uv/ChangeLog:3059:  instead of passing the error code the the exit callback. This brings it on
deps/uv/docs/src/conf.py:119:# The theme to use for HTML and HTML Help pages.  See the documentation for
deps/uv/src/win/tty.c:208:    /* Obtain the the tty_output_lock because the virtual window state is */
deps/v8/include/v8.h:5524:   * This means the the function's prototype.__proto__ is set to the parent
deps/v8/ChangeLog:35438:        This uses a runtime function to set up the the constructor and its
deps/v8/src/ast/scopes.h:711:  // is in an intermediate scope between this function scope and the the
deps/v8/src/base/cpu.cc:462:  // The list is well-known, unlike the the output of
deps/v8/src/base/platform/platform-win32.cc:505:// In order to be able to get debug output in this case the the debugging
deps/v8/src/builtins/builtins-arguments-gen.h:27:  // Calculates and returns the the frame pointer, argument count and formal
deps/v8/src/builtins/builtins-collections-gen.cc:2244:    // This is the the negative form BaseShape::IsLive().
deps/v8/src/builtins/builtins-promise-gen.h:66:  // This is used by the ThenFinally and CatchFinally builtins to
deps/v8/src/compiler/bytecode-graph-builder.cc:785:  // of loop_n (the OSR loop), and then we peel the part of the the body of
deps/v8/src/compiler/code-assembler.h:514:// details don't leak outside of the the compiler directory..
deps/v8/src/compiler/int64-lowering.cc:277:      // not even have to do the default lowering because the the start node,
deps/v8/src/compiler/load-elimination.cc:1294:  // transitions. We kill the the fields later when all the transitions are
deps/v8/src/compiler/simd-scalar-lowering.cc:749:      // not even have to do the default lowering because the the start node,
deps/v8/src/conversions.h:21:// The limit for the the fractionDigits/precision for toFixed, toPrecision
deps/v8/src/disassembler.h:15:  // Decode instructions in the the interval [begin, end) and print the
deps/v8/src/factory.cc:667:  // This makes uses of the the unsigned wraparound.
deps/v8/src/gdb-jit.cc:1738:  // The first state, just after the control has been transferred to the the
deps/v8/src/ic/ic.cc:194:  // function's frame. Check if the there is an additional frame, and if there
deps/v8/src/interpreter/bytecode-generator.cc:644:  // Inverts the control flow of the operation, swapping the then and else
deps/v8/src/interpreter/interpreter-generator.cc:2892:// Returns the next enumerable property in the the accumulator.
deps/v8/src/json-parser.cc:824:    // Fast path for existing internalized strings.  If the the string being
deps/v8/src/macro-assembler.h:143:// Class for scoping the the unavailability of constant pool access.
deps/v8/src/objects/script.h:107:  // [compilation_type]: how the the script was compiled. Encoded in the
deps/v8/src/objects/shared-function-info.h:232:  // Indicates that the the shared function info is deserialized from cache.
deps/v8/src/objects.h:4742:  // the receiver under the the cached_property_name when this
deps/v8/src/objects.cc:11706:    // Go the the next $ in the replacement.
deps/v8/src/regexp/jsregexp.cc:1680:    // trick.  We avoid the theoretical case where negative numbers are
deps/v8/src/runtime/runtime-debug.cc:1196:// args[2]: the the maximum number of objects to return
deps/v8/src/runtime/runtime-debug.cc:1254:// args[1]: the the maximum number of objects to return
deps/v8/src/wasm/module-compiler.cc:4019:    // We reached a section after the code section, we do not need the the
deps/v8/src/wasm/wasm-interpreter.h:174:    // the given id must the the latest activation on the stack.
deps/v8/src/x64/code-stubs-x64.cc:359:    // above the the two Arguments object slots on Win64.
deps/v8/test/cctest/test-api-interceptors.cc:2846:// Make sure that the the interceptor code in the runtime properly handles
deps/v8/test/cctest/test-api-interceptors.cc:2907:// Make sure that the the interceptor code in the runtime properly handles
deps/v8/test/cctest/test-circular-queue.cc:56:  // Try to enqueue when the the queue is full. Consumption must be available.
deps/v8/test/cctest/test-hashmap.cc:157:    // Verify the the expected values are still there.
deps/v8/test/cctest/test-object.cc:159:  // Initializing the EnumCache for the the topmost map {a} will not create the
deps/v8/test/mjsunit/es6/reflect-prevent-extensions.js:97:// Test the the extensible flag is not inherited.
deps/v8/test/mjsunit/object-prevent-extensions.js:96:// Test the the extensible flag is not inherited.
deps/v8/test/mjsunit/regress/regress-2443.js:78:// Note that the the last two steps are reversed for toFixed.
deps/v8/test/mjsunit/unicode-test.js:5998:"    by making all allocations from the the `lowest' part of any found\n" +
deps/v8/third_party/jinja2/runtime.py:335:    # the the loop without or with too many arguments.
deps/zlib/contrib/minizip/unzip.c:595:    uLong number_disk_with_CD;  /* number the the disk with central dir, used
deps/zlib/contrib/minizip/zip.c:652:  uLong number_disk_with_CD;  /* number the the disk with central dir, used
deps/zlib/contrib/minizip/zip.h:175:    contains the extrafield data the the local header
deps/zlib/contrib/minizip/zip.h:177:    contains the extrafield data the the local header
deps/zlib/examples/gzlog.c:215:     For the the compress recovery, a missing foo.add file results in foo.gz
deps/zlib/old/visual-basic.txt:118:            Put #1, , lngOriSiz 'Add the the original size value to the end
deps/zlib/win32/README-WIN32.txt:19:PLEASE read DLL_FAQ.txt, and the the zlib FAQ http://zlib.net/zlib_faq.html
deps/zlib/zlib.h:732:   applied to the the data compressed after deflateParams().
doc/api/async_hooks.md:457:  before 6               # the then() callback is entered
doc/api/async_hooks.md:458:  promise resolve 6      # the then() callback resolves the promise by returning
doc/changelogs/CHANGELOG_V7.md:503:* [[`5bea8b42d9`](https://github.com/nodejs/node/commit/5bea8b42d9)] - **doc**: fix occurences of "the the" (Jeroen Mandersloot) [#11711](https://github.com/nodejs/node/pull/11711)
doc/changelogs/CHANGELOG_V7.md:1802:* [[`c18ca1593e`](https://github.com/nodejs/node/commit/c18ca1593e)] - **doc**: fix tls "the the" typo (Sam Roberts) [#9665](https://github.com/nodejs/node/pull/9665)
doc/changelogs/CHANGELOG_V8.md:2477:* [[`816f98f5d0`](https://github.com/nodejs/node/commit/816f98f5d0)] - **console**: use a plain object for the the error stack (Ruben Bridgewater) [#13743](https://github.com/nodejs/node/pull/13743)
doc/changelogs/CHANGELOG_V6.md:1931:* [[`0acebb985f`](https://github.com/nodejs/node/commit/0acebb985f)] - **doc**: fix occurences of "the the" (Jeroen Mandersloot) [#11711](https://github.com/nodejs/node/pull/11711)
doc/changelogs/CHANGELOG_V6.md:2713:* [[`1a58a21d29`](https://github.com/nodejs/node/commit/1a58a21d29)] - **doc**: fix tls "the the" typo (Sam Roberts) [#9665](https://github.com/nodejs/node/pull/9665)
tools/gyp/pylib/gyp/generator/make.py:22:# the side to keep the the files readable.
tools/gyp/pylib/gyp/generator/ninja.py:143:    # so that the the target that directly depends on the .objs can also depend
tools/gyp/pylib/gyp/MSVSSettings.py:420:  """Convert the the MSVS macros found in the string to the MSBuild equivalent.
tools/gyp/pylib/gyp/win_tool.py:180:    # Run mt.exe on the theoretically complete manifest we generated, merging
tools/msvs/msi/i18n/en-us.wxl:25:    <String Id="DocumentationShortcuts_Description">Add start menu entries that link the the online documentation for [ProductName] [FullVersion] and the [ProductName] website.</String>
@Trott
Copy link
Member

Trott commented May 11, 2018

All the occurrences in deps would have to be fixed in upstream repositories (if they aren't false positives).

All the occurrences in doc are false positives (e.g., "the then() callback is entered") except for one instance in a CHANGELOG that is a typo inherited from a commit message. That seems unlikely to be changed IMO, but I could be wrong.

That leaves five occurrences in tools, one of which is a false positive ("the theoretically complete").

@ChALkeR
Copy link
Member

ChALkeR commented May 11, 2018

  1. deps and node_modules are third-party dependencies, any documentation/comment mistypes inside those are out of scope here.
  2. the then() callback and similar are not the the mistypes.
  3. Several more are commits with message like fix occurences of "the the" in the changelog.
$ grep -r 'the the' --exclude-dir=deps --exclude-dir=out --exclude-dir=node_modules | wc -l
12
$ grep -r 'the the ' --exclude-dir=deps --exclude-dir=out --exclude-dir=node_modules | wc -l
5

Full output for the remaining ones:

$ grep -r 'the the ' --exclude-dir=deps --exclude-dir=out --exclude-dir=node_modules
tools/msvs/msi/i18n/en-us.wxl:    <String Id="DocumentationShortcuts_Description">Add start menu entries that link the the online documentation for [ProductName] [FullVersion] and the [ProductName] website.</String>
tools/gyp/pylib/gyp/MSVSSettings.py:  """Convert the the MSVS macros found in the string to the MSBuild equivalent.
tools/gyp/pylib/gyp/generator/make.py:# the side to keep the the files readable.
tools/gyp/pylib/gyp/generator/ninja.py:    # so that the the target that directly depends on the .objs can also depend
doc/changelogs/CHANGELOG_V8.md:* [[`816f98f5d0`](https://github.com/nodejs/node/commit/816f98f5d0)] - **console**: use a plain object for the the error stack (Ruben Bridgewater) [#13743](https://github.com/nodejs/node/pull/13743)

Upd: ah, @Trott beat me to it by seconds. 😆

@gireeshpunathil
Copy link
Member

I had spotted a few in the past, which I saved and leveraged for a code & learn activity. :) It is possible that this is a common typo pattern that recur.

@shisama shisama mentioned this issue May 14, 2018
1 task
shisama pushed a commit to shisama/node that referenced this issue May 14, 2018
Fix typo `the the`.

Fixes: nodejs#20682
MylesBorins pushed a commit that referenced this issue May 22, 2018
PR-URL: #20716
Fixes: #20682
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit to nodejs/node-gyp that referenced this issue Aug 9, 2018
PR-URL: nodejs/node#20716
Fixes: nodejs/node#20682
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit to nodejs/node-gyp that referenced this issue Aug 9, 2018
PR-URL: nodejs/node#20716
Fixes: nodejs/node#20682
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BaochengSu pushed a commit to BaochengSu/node that referenced this issue Oct 20, 2020
PR-URL: nodejs#20716
Fixes: nodejs#20682
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit 3b1bf0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants