Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-http-server-keep-alive-timeout #20013

Closed
Trott opened this issue Apr 13, 2018 · 2 comments
Closed

Investigate flaky parallel/test-http-server-keep-alive-timeout #20013

Trott opened this issue Apr 13, 2018 · 2 comments
Labels
confirmed-bug Issues with confirmed bugs. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Apr 13, 2018

  • Version: v10.0.0-pre (master)
  • Platform: freebsd10-64
  • Subsystem: test http

https://ci.nodejs.org/job/node-test-commit-freebsd/16985/nodes=freebsd10-64/console

not ok 783 parallel/test-http-server-keep-alive-timeout
  ---
  duration_ms: 2.29
  severity: fail
  exitcode: 1
  stack: |-
    Mismatched <anonymous> function calls. Expected exactly 3, actual 1.
        at Object.exports.mustCall (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common/index.js:427:10)
        at serverEndKeepAliveTimeoutWithPipeline (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-http-server-keep-alive-timeout.js:22:43)
        at run (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-http-server-keep-alive-timeout.js:18:11)
        at process._tickCallback (internal/process/next_tick.js:172:11)
        at Function.Module.runMain (internal/modules/cjs/loader.js:721:11)
        at startup (internal/bootstrap/node.js:228:19)
        at bootstrapNodeJSCore (internal/bootstrap/node.js:575:3)
  ...
@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Apr 13, 2018
@Trott
Copy link
Member Author

Trott commented Apr 13, 2018

Stress test to see if it is reproducible:

https://ci.nodejs.org/job/node-stress-single-test/1816/

@Trott
Copy link
Member Author

Trott commented Apr 13, 2018

Stress test failed:

16:11:29 not ok 1 parallel/test-http-server-keep-alive-timeout
16:11:29   ---
16:11:29   duration_ms: 8.686
16:11:29   severity: fail
16:11:29   exitcode: 1
16:11:29   stack: |-
16:11:29     Mismatched <anonymous> function calls. Expected exactly 3, actual 0.
16:11:29         at Object.exports.mustCall (/usr/home/iojs/build/workspace/node-stress-single-test/nodes/freebsd10-64/test/common/index.js:427:10)
16:11:29         at serverEndKeepAliveTimeoutWithPipeline (/usr/home/iojs/build/workspace/node-stress-single-test/nodes/freebsd10-64/test/parallel/test-http-server-keep-alive-timeout.js:22:43)
16:11:29         at run (/usr/home/iojs/build/workspace/node-stress-single-test/nodes/freebsd10-64/test/parallel/test-http-server-keep-alive-timeout.js:18:11)
16:11:29         at process._tickCallback (internal/process/next_tick.js:172:11)
16:11:29         at Function.Module.runMain (internal/modules/cjs/loader.js:721:11)
16:11:29         at startup (internal/bootstrap/node.js:228:19)
16:11:29         at bootstrapNodeJSCore (internal/bootstrap/node.js:575:3)
16:11:29   ...

@Trott Trott added the confirmed-bug Issues with confirmed bugs. label Apr 13, 2018
santigimeno added a commit to santigimeno/node that referenced this issue Apr 17, 2018
@santigimeno
test: fix flaky http-server-keep-alive-timeout
61e6ba2 
Make sure the connection is not closed until the 3 requests and the
`timeout` event are received.
Some code refactoring to avoid duplicated code.

Fixes: nodejs#20013
@santigimeno santigimeno mentioned this issue Apr 17, 2018
Closed
4 tasks
jasnell pushed a commit that referenced this issue Apr 20, 2018
@santigimeno @jasnell
test: fix flaky http-server-keep-alive-timeout
392ed93 
Make sure the connection is not closed until the 3 requests and the
`timeout` event are received.
Some code refactoring to avoid duplicated code.

Fixes: #20013
PR-URL: #20093
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jun 3, 2020
Open
Open
@snyk-bot snyk-bot mentioned this issue Jun 14, 2020
Open
@kissofire kissofire mentioned this issue Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky http-server-keep-alive-timeout santigimeno/node
1 participant
@Trott