Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raspberry Pi 1 test failure test-timers-unrefd-interval-still-fires.js #1781

Closed
rvagg opened this issue May 24, 2015 · 7 comments
Closed

Raspberry Pi 1 test failure test-timers-unrefd-interval-still-fires.js #1781

rvagg opened this issue May 24, 2015 · 7 comments
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests.

Comments

@rvagg
Copy link
Member

rvagg commented May 24, 2015

not ok 659 - test-timers-unrefd-interval-still-fires.js
#
#assert.js:88
#  throw new assert.AssertionError({
#        ^
#AssertionError: 3 === 5
#    at onTimeout [as _onTimeout] (/home/iojs/build/workspace/iojs+any-pr+multi/nodes/pi1-raspbian-wheezy/test/parallel/test-timers-unrefd-interval-still-fires.js:18:10)
#    at Timer.listOnTimeout (timers.js:89:15)

Probably an intermittent and this is running on an original Pi B, not a B+ so very likely time-related, but regardless, we need to make it more robust.

@rvagg rvagg changed the title Raspberry Pi 1 test failure Raspberry Pi 1 test failure test-timers-unrefd-interval-still-fires.js May 24, 2015
@Fishrock123
Copy link
Contributor

Looks like it's timing related, but if it is that means only 3 timers set to 1ms are managing to fire in 100ms..

@brendanashworth brendanashworth added the test Issues and PRs related to the tests. label May 24, 2015
@silverwind
Copy link
Contributor

Gues we could try platformTimeout, but 100ms seems plenty for such a simple task.

@silverwind
Copy link
Contributor

Couldn't reproduce in 1000 runs on a 700 Mhz RPi B model using 2.1.0 release. Trying master now.

@brendanashworth brendanashworth added the arm Issues and PRs related to the ARM platform. label Jul 13, 2015
@Fishrock123
Copy link
Contributor

@silverwind did you ever reproduce this? I feel like I haven't seen it in a while.

@silverwind
Copy link
Contributor

Don't think so. I've already replaced my RPi with a RPi2, so can't test anymore.

@silverwind
Copy link
Contributor

If it still happens on CI, we can just use platformTimeout.

@Fishrock123
Copy link
Contributor

Closing, we haven't seen it recently.

(Also I don't actually believe that test can take more than 100ms besides startup...)

Fishrock123 pushed a commit to Fishrock123/node that referenced this issue Nov 20, 2015
Rely more on timers implementation rather than arbitrary timeouts.

Refs: nodejs#1781
PR-URL: nodejs#3550

Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this issue Dec 5, 2015
Rely more on timers implementation rather than arbitrary timeouts.

Refs: #1781
PR-URL: #3550

Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this issue Dec 29, 2015
Rely more on timers implementation rather than arbitrary timeouts.

Refs: #1781
PR-URL: #3550

Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
Rely more on timers implementation rather than arbitrary timeouts.

Refs: #1781
PR-URL: #3550

Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants