-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the bench-* targets in makefile? #17053
Comments
joyeecheung
added
build
Issues and PRs related to build files or the CI.
benchmark
Issues and PRs related to the benchmark subsystem.
labels
Nov 15, 2017
cc @nodejs/build @nodejs/performance @nodejs/benchmarking |
SGTM |
SGTM too, |
not aware of anyone else using it, so sgtm and +1 for decluttering Makefile in general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi all, just wondering is there anyone actually using the bench-* targets in the Makefile? This is not used by the benchmark CI, and basically those just call
./node benchmark/run.js *
which is not really that hard to remember (and this does not even allow you to set the arguments at all. Besides, these days we tend to usebenchmark/compare.js
instead). Thebench-all
andbench
target somehow only run a subset of the benchmarks and they are not covering all the categories that we have anyway. Based on this I think those are not maintained and not really used anymore so I am just wondering maybe we can remove those altogether.Refs: #16934
The text was updated successfully, but these errors were encountered: