Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation, dns.resolvePtr(hostname) missing callback argument #12161

Closed
codepilot opened this issue Apr 2, 2017 · 2 comments
Closed

Documentation, dns.resolvePtr(hostname) missing callback argument #12161

codepilot opened this issue Apr 2, 2017 · 2 comments
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@codepilot
Copy link

  • Version: v7.8.0
  • Platform: Windows 10 Pro x64
  • Subsystem: Documentation

https://nodejs.org/dist/latest-v7.x/docs/api/dns.html#dns_dns_resolveptr_hostname

dns.resolvePtr(hostname)

Should be

dns.resolvePtr(hostname, callback)
@mscdex mscdex added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Apr 2, 2017
@ghost ghost mentioned this issue Apr 3, 2017
Closed
2 tasks
@uppinder uppinder mentioned this issue Apr 6, 2017
Closed
2 tasks
uppinder added a commit to uppinder/node that referenced this issue Apr 6, 2017
@uppinder
doc: fix missing callback argument dns.resolvePtr
29084c7 
Fixes: nodejs#12161
@vsemozhetbyt
Copy link
Contributor

@codepilot Thank you!

italoacasas pushed a commit to italoacasas/node that referenced this issue Apr 10, 2017
@uppinder @italoacasas
doc: fix missing argument for dns.resolvePtr()
6826637 
PR-URL: nodejs#12256
Fixes: nodejs#12161
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codepilot
Copy link
Author

codepilot commented Apr 11, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix missing callback for dns.resolvePtr() uppinder/node
3 participants
@mscdex @codepilot @vsemozhetbyt