core: throw TypeError if chdir() args are wrong

nodejs · Jan 9, 2015 · f8666bf · f8666bf
1 parent b8891d6
commit f8666bf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -1499,8 +1499,7 @@ static void Chdir(const FunctionCallbackInfo<Value>& args) {
   Environment* env = Environment::GetCurrent(args);
 
   if (args.Length() != 1 || !args[0]->IsString()) {
-    // FIXME(bnoordhuis) ThrowTypeError?
-    return env->ThrowError("Bad argument.");
+    return env->ThrowTypeError("Bad argument.");
   }
 
   node::Utf8Value path(args.GetIsolate(), args[0]);

diff --git a/test/sequential/test-chdir.js b/test/sequential/test-chdir.js
@@ -38,3 +38,8 @@ assert(process.cwd() == dir);
 process.chdir('..');
 assert(process.cwd() == path.resolve(common.fixturesDir));
 fs.rmdirSync(dir);
+
+assert.throws(function() { process.chdir({}); }, TypeError, 'Bad argument.');
+assert.throws(function() { process.chdir(); }, TypeError, 'Bad argument.');
+assert.throws(function() { process.chdir("x", "y"); }, TypeError, 'Bad argument.');
+