Skip to content

Commit

Permalink
fixup! readline: add readline.promises
Browse files Browse the repository at this point in the history
Remove the readline.promises experimental warning per
PR review comment.
  • Loading branch information
cjihrig committed Jul 10, 2019
1 parent 11c8737 commit edcdf05
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
5 changes: 1 addition & 4 deletions lib/readline.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ let promises;
Object.defineProperties(module.exports, {
promises: {
configurable: true,
enumerable: false,
enumerable: true,
get() {
if (promises === undefined) {
const {
Expand All @@ -69,9 +69,6 @@ Object.defineProperties(module.exports, {
emitKeypressEvents,
moveCursor
};

process.emitWarning('The readline.promises API is experimental',
'ExperimentalWarning');
}
return promises;
}
Expand Down
4 changes: 0 additions & 4 deletions test/parallel/test-readline-promises.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ const common = require('../common');
const assert = require('assert');
const readline = require('readline');
const { PassThrough } = require('stream');

common.expectWarning('ExperimentalWarning',
'The readline.promises API is experimental');

const promises = readline.promises;

{
Expand Down

0 comments on commit edcdf05

Please sign in to comment.