src: do not read string out of bounds

nodejs · Jan 4, 2024 · c778390 · c778390
1 parent 084d761
commit c778390
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/src/path.cc b/src/path.cc
@@ -24,16 +24,8 @@ std::string NormalizeString(const std::string_view path,
   int lastSegmentLength = 0;
   int lastSlash = -1;
   int dots = 0;
-  char code;
-  const auto pathLen = path.size();
-  for (uint8_t i = 0; i <= pathLen; ++i) {
-    if (i < pathLen) {
-      code = path[i];
-    } else if (IsPathSeparator(path[i])) {
-      break;
-    } else {
-      code = node::kPathSeparator;
-    }
+  for (size_t i = 0; i < path.size(); ++i) {
+    char code = path[i];
 
     if (IsPathSeparator(code)) {
       if (lastSlash == static_cast<int>(i - 1) || dots == 1) {