Skip to content

Commit

Permalink
tools: change editorconfig's 'ignore' to 'unset'
Browse files Browse the repository at this point in the history
According to https://editorconfig.org/#supported-properties the
canonical way to disable a property is to set it to 'unset'. We did use
'ignore' and this generally works because tools ignore unknown values
but some of them like `eclint` are picky on it.

PR-URL: #28440
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
silverwind authored and targos committed Jul 2, 2019
1 parent 4367732 commit b808484
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ indent_size = 8
indent_style = tab

[{deps}/**]
charset = ignore
end_of_line = ignore
indent_size = ignore
indent_style = ignore
trim_trailing_whitespace = ignore
charset = unset
end_of_line = unset
indent_size = unset
indent_style = unset
trim_trailing_whitespace = unset

[{test/fixtures,deps,tools/node_modules,tools/gyp,tools/icu,tools/msvs}/**]
insert_final_newline = false

0 comments on commit b808484

Please sign in to comment.