Skip to content

Commit

Permalink
url: use existing handlers instead of duplicated code
Browse files Browse the repository at this point in the history
PR-URL: #19267
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
daynin authored and BridgeAR committed Apr 9, 2018
1 parent b34a1e1 commit a892d9a
Showing 1 changed file with 7 additions and 14 deletions.
21 changes: 7 additions & 14 deletions lib/internal/url.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,20 +256,6 @@ function onParseProtocolComplete(flags, protocol, username, password,
ctx.port = port;
}

function onParseHostComplete(flags, protocol, username, password,
host, port, path, query, fragment) {
const ctx = this[context];
if ((flags & URL_FLAGS_HAS_HOST) !== 0) {
ctx.host = host;
ctx.flags |= URL_FLAGS_HAS_HOST;
} else {
ctx.host = null;
ctx.flags &= ~URL_FLAGS_HAS_HOST;
}
if (port !== null)
ctx.port = port;
}

function onParseHostnameComplete(flags, protocol, username, password,
host, port, path, query, fragment) {
const ctx = this[context];
Expand All @@ -287,6 +273,13 @@ function onParsePortComplete(flags, protocol, username, password,
this[context].port = port;
}

function onParseHostComplete(flags, protocol, username, password,
host, port, path, query, fragment) {
onParseHostnameComplete.apply(this, arguments);
if (port !== null)
onParsePortComplete.apply(this, arguments);
}

function onParsePathComplete(flags, protocol, username, password,
host, port, path, query, fragment) {
const ctx = this[context];
Expand Down

0 comments on commit a892d9a

Please sign in to comment.