Skip to content

Commit

Permalink
src: moving f function call comment
Browse files Browse the repository at this point in the history
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

PR-URL: #8405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
danbev committed Sep 5, 2016
1 parent e4ac083 commit a01e8bc
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3388,14 +3388,6 @@ void LoadEnvironment(Environment* env) {
CHECK(f_value->IsFunction());
Local<Function> f = Local<Function>::Cast(f_value);

// Now we call 'f' with the 'process' variable that we've built up with
// all our bindings. Inside bootstrap_node.js we'll take care of
// assigning things to their places.

// We start the process this way in order to be more modular. Developers
// who do not like how bootstrap_node.js setups the module system but do
// like Node's I/O bindings may want to replace 'f' with their own function.

// Add a reference to the global object
Local<Object> global = env->context()->Global();

Expand Down Expand Up @@ -3425,6 +3417,13 @@ void LoadEnvironment(Environment* env) {
// (Allows you to set stuff on `global` from anywhere in JavaScript.)
global->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "global"), global);

// Now we call 'f' with the 'process' variable that we've built up with
// all our bindings. Inside bootstrap_node.js we'll take care of

This comment has been minimized.

Copy link
@Fishrock123

Fishrock123 Sep 5, 2016

Contributor

"Inside bootstrap_node.js and internal/process"

This comment has been minimized.

Copy link
@danbev

danbev Sep 5, 2016

Author Contributor

@Fishrock123 Sorry about not allowing enough review time and having already merged this. I'll create a new PR with this update.

// assigning things to their places.

// We start the process this way in order to be more modular. Developers
// who do not like how bootstrap_node.js setups the module system but do

This comment has been minimized.

Copy link
@cjihrig

cjihrig Sep 5, 2016

Contributor

setups -> sets up

This comment has been minimized.

Copy link
@danbev

danbev Sep 5, 2016

Author Contributor

@cjihrig Sorry about not allowing enough review time and having already merged this. I'll create a new PR with this update and the update from @Fishrock123.

// like Node's I/O bindings may want to replace 'f' with their own function.
Local<Value> arg = env->process_object();
f->Call(Null(env->isolate()), 1, &arg);
}
Expand Down

0 comments on commit a01e8bc

Please sign in to comment.