Skip to content

Commit

Permalink
deps: turn in std::string for ICU
Browse files Browse the repository at this point in the history
- node and v8 did not call into std::string previously,
so that access was shut off.
- this fixes compilation for ICU 58.2 (backlevel) but may
be expressed in other versions also.

Fixes: #19151

PR-URL: #19624
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
  • Loading branch information
srl295 authored and targos committed Apr 2, 2018
1 parent 2c5d53f commit 97a92c4
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions tools/icu/icu-generic.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@
'UCONFIG_NO_REGULAR_EXPRESSIONS=1',
'U_ENABLE_DYLOAD=0',
'U_STATIC_IMPLEMENTATION=1',
# Don't need std::string in API.
# Also, problematic: <http://bugs.icu-project.org/trac/ticket/11333>
'U_HAVE_STD_STRING=0',
'U_HAVE_STD_STRING=1',
# TODO(srl295): reenable following pending
# https://code.google.com/p/v8/issues/detail?id=3345
# (saves some space)
Expand Down

0 comments on commit 97a92c4

Please sign in to comment.