Skip to content

Commit

Permalink
test: add comments explaining _setSimultaneousAccepts deprecation tests
Browse files Browse the repository at this point in the history
PR-URL: #41307
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
kuriyosh authored and danielleadams committed Feb 1, 2022
1 parent ffca1a7 commit 8d15bac
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
2 changes: 2 additions & 0 deletions test/parallel/test-net-deprecated-setsimultaneousaccepts.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Flags: --no-warnings
'use strict';

// Test that DEP0121 is emitted on the first call of _setSimultaneousAccepts().

const {
expectWarning
} = require('../common');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
'use strict';

// Test that DEP0121 is emitted only once if _setSimultaneousAccepts() is called
// more than once. This test is similar to
// test-net-deprecated-setsimultaneousaccepts.js, but that test calls
// _setSimultaneousAccepts() only once. Unlike this test, that will confirm
// that the warning is emitted on the first call. This test doesn't check which
// call caused the warning to be emitted.

const { expectWarning } = require('../common');
const net = require('net');
const { _setSimultaneousAccepts } = require('net');

expectWarning(
'DeprecationWarning',
'net._setSimultaneousAccepts() is deprecated and will be removed.',
'DEP0121');

net._setSimultaneousAccepts();
net._setSimultaneousAccepts();
_setSimultaneousAccepts();
_setSimultaneousAccepts();

0 comments on commit 8d15bac

Please sign in to comment.