Use stack emplace rather than push

This avoids creating a temporary v8::Global
nodejs · Dec 19, 2019 · 6b12f77 · 6b12f77
1 parent d08abdb
commit 6b12f77
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/env-inl.h b/src/env-inl.h
@@ -207,9 +207,8 @@ inline AsyncHooks::DefaultTriggerAsyncIdScope ::~DefaultTriggerAsyncIdScope() {
 }
 
 inline void AsyncHooks::push_execution_async_resource(
-  v8::Local<v8::Value> execution_async_resource) {
-  execution_async_resources_.push(v8::Global<v8::Value>(
-    env()->isolate(), execution_async_resource));
+  v8::Local<v8::Value> resource) {
+  execution_async_resources_.emplace(env()->isolate(), resource);
 }
 
 inline void AsyncHooks::pop_execution_async_resource() {