Skip to content

Commit

Permalink
doc: add saghul as a collaborator
Browse files Browse the repository at this point in the history 
PR_URL: #3724
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
  • Loading branch information
@saghul
saghul committed Nov 9, 2015
1 parent 354f9ce commit 64208ef
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ information about the governance of the Node.js project, see
* [qard](https://github.com/qard) - **Stephen Belanger** &lt;admin@stephenbelanger.com&gt;
* [rlidwka](https://github.com/rlidwka) - **Alex Kocharin** &lt;alex@kocharin.ru&gt;
* [robertkowalski](https://github.com/robertkowalski) - **Robert Kowalski** &lt;rok@kowalski.gd&gt;
* [saghul](https://github.com/saghul) - **Saúl Ibarra Corretgé** &lt;saghul@gmail.com&gt;
* [sam-github](https://github.com/sam-github) - **Sam Roberts** &lt;vieuxtech@gmail.com&gt;
* [seishun](https://github.com/seishun) - **Nikolai Vavilov** &lt;vvnicholas@gmail.com&gt;
* [silverwind](https://github.com/silverwind) - **Roman Reiss** &lt;me@silverwind.io&gt;
Expand Down

4 comments on commit 64208ef

@Fishrock123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul @romankl @thealphanerd

Note: our tooling will recognize PR_URL:, but we prefer PR-URL: :)

@saghul
Copy link
Member Author

@saghul saghul commented on 64208ef Nov 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, gotta make the first mistake on second 1! I blame the reviewers :-P

@MylesBorins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUT WHO REVIEWS THE REVIEWERS

:P

@Fishrock123
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't often do this, but it is possible to push this info up to the PR branch first before landing. Perhaps we should suggest that in #3726

(Don't worry, worse mistakes have been made by yours truly)

Please sign in to comment.