Skip to content

Commit

Permalink
lib: enable dot-notation eslint rule
Browse files Browse the repository at this point in the history
PR-URL: #18007
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
  • Loading branch information
apapirovski authored and MylesBorins committed Jan 10, 2018
1 parent 371b230 commit 5d7eb3d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions lib/.eslintrc.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
rules:
dot-notation: error

# Custom rules in tools/eslint-rules
require-buffer: error
buffer-constructor: error
Expand Down
2 changes: 1 addition & 1 deletion lib/inspector.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class Session extends EventEmitter {
const id = this[nextIdSymbol]++;
const message = { id, method };
if (params) {
message['params'] = params;
message.params = params;
}
if (callback) {
this[messageCallbacksSymbol].set(id, callback);
Expand Down
4 changes: 2 additions & 2 deletions lib/internal/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ const { signals } = process.binding('constants').os;

const { createPromise, promiseResolve, promiseReject } = binding;

const kArrowMessagePrivateSymbolIndex = binding['arrow_message_private_symbol'];
const kDecoratedPrivateSymbolIndex = binding['decorated_private_symbol'];
const kArrowMessagePrivateSymbolIndex = binding.arrow_message_private_symbol;
const kDecoratedPrivateSymbolIndex = binding.decorated_private_symbol;
const noCrypto = !process.versions.openssl;

const experimentalWarnings = new Set();
Expand Down
2 changes: 1 addition & 1 deletion lib/module.js
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ Module._initPaths = function() {
paths.unshift(path.resolve(homeDir, '.node_modules'));
}

var nodePath = process.env['NODE_PATH'];
var nodePath = process.env.NODE_PATH;
if (nodePath) {
paths = nodePath.split(path.delimiter).filter(function(path) {
return !!path;
Expand Down

0 comments on commit 5d7eb3d

Please sign in to comment.