Skip to content

Commit

Permalink
build: define HAVE_OPENSSL macro for cctest
Browse files Browse the repository at this point in the history
cctest build target wasn't defining the HAVE_OPENSSL macro when
node_use_openssl was true, causing inconsistencies on most
`node::Environment` member's addresses. For example, if someone
wanted to access the context of an environment by using
`node::Environment::context()`, the object returned by the
function was pointing to an invalid address.

PR-URL: #17461
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
Matheus Marchini authored and MylesBorins committed Dec 12, 2017
1 parent c951e2c commit 5d1463a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,9 @@
'<(OBJ_PATH)<(OBJ_SEPARATOR)node_crypto_clienthello.<(OBJ_SUFFIX)',
'<(OBJ_PATH)<(OBJ_SEPARATOR)tls_wrap.<(OBJ_SUFFIX)',
],
'defines': [
'HAVE_OPENSSL=1',
],
}],
['v8_enable_inspector==1', {
'sources': [
Expand Down

0 comments on commit 5d1463a

Please sign in to comment.