Skip to content

Commit

Permalink
build: cleanup in .gitignore
Browse files Browse the repository at this point in the history
* explicitly unignore files that we track.

The following are not created anymore (only as subdirs of v8/gypfiles)
/deps/v8/src/debug/obj
deps/v8/src/Debug/
deps/v8/src/Release/
deps/v8/src/inspector/Debug/
deps/v8/src/inspector/Release/

PR-URL: #23180
Refs: #23156
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
refack committed Oct 4, 2018
1 parent a4ffa0c commit 5af1ac6
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
!.mailmap
!.nycrc
!.travis.yml
!.eslintrc.yaml

core
vgcore.*
Expand All @@ -38,14 +39,15 @@ icu_config.gypi
.eslintcache
node_trace.*.log
coverage/
!**/node_modules/**/coverage

/out

# various stuff that VC++ produces/uses
Debug/
!**/node_modules/debug/
!deps/v8/src/debug/
Release/
!**/node_modules/**/release
!doc/blog/**
*.sln
!nodemsi.sln
Expand All @@ -64,7 +66,6 @@ ipch/
*.VC.opendb
.vs/
.vscode/
/deps/v8/src/debug/obj
/*.exe

/config.mk
Expand Down Expand Up @@ -98,6 +99,7 @@ deps/openssl/openssl.xml
deps/openssl/openssl.target.mk
deps/zlib/zlib.target.mk

!deps/npm/node_modules
# not needed and causes issues for distro packagers
deps/npm/node_modules/.bin/

Expand Down Expand Up @@ -130,8 +132,4 @@ deps/uv/docs/src/guide/
# ignore VS compiler output unhandled by V8's .gitignore
deps/v8/gypfiles/Debug/
deps/v8/gypfiles/Release/
deps/v8/src/Debug/
deps/v8/src/Release/
deps/v8/src/inspector/Debug/
deps/v8/src/inspector/Release/
deps/v8/third_party/eu-strip/

0 comments on commit 5af1ac6

Please sign in to comment.