benchmark: (fs) use destructuring

PR-URL: #18250 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Jan 30, 2018 · 59271c8 · 59271c8
1 parent 4e19cbe
commit 59271c8
Show file tree

Hide file tree

Showing 10 changed files with 12 additions and 33 deletions.
diff --git a/benchmark/fs/bench-readdir.js b/benchmark/fs/bench-readdir.js
@@ -9,9 +9,7 @@ const bench = common.createBenchmark(main, {
 });
 
 
-function main(conf) {
-  const n = conf.n >>> 0;
-
+function main({ n }) {
   bench.start();
   (function r(cntr) {
     if (cntr-- <= 0)

diff --git a/benchmark/fs/bench-readdirSync.js b/benchmark/fs/bench-readdirSync.js
@@ -9,9 +9,7 @@ const bench = common.createBenchmark(main, {
 });
 
 
-function main(conf) {
-  const n = conf.n >>> 0;
-
+function main({ n }) {
   bench.start();
   for (var i = 0; i < n; i++) {
     fs.readdirSync(path.resolve(__dirname, '../../lib/'));

diff --git a/benchmark/fs/bench-realpath.js b/benchmark/fs/bench-realpath.js
@@ -12,10 +12,7 @@ const bench = common.createBenchmark(main, {
 });
 
 
-function main(conf) {
-  const n = conf.n >>> 0;
-  const pathType = conf.pathType;
-
+function main({ n, pathType }) {
   bench.start();
   if (pathType === 'relative')
     relativePath(n);

diff --git a/benchmark/fs/bench-realpathSync.js b/benchmark/fs/bench-realpathSync.js
@@ -14,10 +14,7 @@ const bench = common.createBenchmark(main, {
 });
 
 
-function main(conf) {
-  const n = conf.n >>> 0;
-  const pathType = conf.pathType;
-
+function main({ n, pathType }) {
   bench.start();
   if (pathType === 'relative')
     relativePath(n);

diff --git a/benchmark/fs/bench-stat.js b/benchmark/fs/bench-stat.js
@@ -9,9 +9,7 @@ const bench = common.createBenchmark(main, {
 });
 
 
-function main(conf) {
-  const n = conf.n >>> 0;
-  const statType = conf.statType;
+function main({ n, statType }) {
   var arg;
   if (statType === 'fstat')
     arg = fs.openSync(__filename, 'r');

diff --git a/benchmark/fs/bench-statSync.js b/benchmark/fs/bench-statSync.js
@@ -9,9 +9,7 @@ const bench = common.createBenchmark(main, {
 });
 
 
-function main(conf) {
-  const n = conf.n >>> 0;
-  const statSyncType = conf.statSyncType;
+function main({ n, statSyncType }) {
   const arg = (statSyncType === 'fstatSync' ?
     fs.openSync(__filename, 'r') :
     __dirname);

diff --git a/benchmark/fs/read-stream-throughput.js b/benchmark/fs/read-stream-throughput.js
@@ -18,7 +18,7 @@ const bench = common.createBenchmark(main, {
 
 function main(conf) {
   encodingType = conf.encodingType;
-  size = +conf.size;
+  size = conf.size;
   filesize = conf.filesize;
 
   switch (encodingType) {

diff --git a/benchmark/fs/readFileSync.js b/benchmark/fs/readFileSync.js
@@ -7,9 +7,7 @@ const bench = common.createBenchmark(main, {
   n: [60e4]
 });
 
-function main(conf) {
-  const n = +conf.n;
-
+function main({ n }) {
   bench.start();
   for (var i = 0; i < n; ++i)
     fs.readFileSync(__filename);

diff --git a/benchmark/fs/readfile.js b/benchmark/fs/readfile.js
@@ -15,8 +15,7 @@ const bench = common.createBenchmark(main, {
   concurrent: [1, 10]
 });
 
-function main(conf) {
-  const len = +conf.len;
+function main({ len, dur, concurrent }) {
   try { fs.unlinkSync(filename); } catch (e) {}
   var data = Buffer.alloc(len, 'x');
   fs.writeFileSync(filename, data);
@@ -30,7 +29,7 @@ function main(conf) {
     bench.end(reads);
     try { fs.unlinkSync(filename); } catch (e) {}
     process.exit(0);
-  }, +conf.dur * 1000);
+  }, dur * 1000);
 
   function read() {
     fs.readFile(filename, afterRead);
@@ -48,6 +47,5 @@ function main(conf) {
       read();
   }
 
-  var cur = +conf.concurrent;
-  while (cur--) read();
+  while (concurrent--) read();
 }
diff --git a/benchmark/fs/write-stream-throughput.js b/benchmark/fs/write-stream-throughput.js
@@ -13,10 +13,7 @@ const bench = common.createBenchmark(main, {
   size: [2, 1024, 65535, 1024 * 1024]
 });
 
-function main(conf) {
-  const dur = +conf.dur;
-  const encodingType = conf.encodingType;
-  const size = +conf.size;
+function main({ dur, encodingType, size }) {
   var encoding;
 
   var chunk;