Skip to content

Commit

Permalink
n-api: create N-API version 7
Browse files Browse the repository at this point in the history
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as
stable.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #35199
Backport-PR-URL: #35336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <mdawson@devrus.com>
  • Loading branch information
Gabriel Schulhof authored and richardlau committed Oct 7, 2020
1 parent b83f9a5 commit 54c2bc2
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 10 deletions.
6 changes: 2 additions & 4 deletions doc/api/n-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -2951,10 +2951,9 @@ of the ECMAScript Language Specification.
### napi_detach_arraybuffer
<!-- YAML
added: v10.22.0
napiVersion: 7
-->

> Stability: 1 - Experimental

```C
napi_status napi_detach_arraybuffer(napi_env env,
napi_value arraybuffer)
Expand All @@ -2977,10 +2976,9 @@ defined in [Section 24.1.1.3][] of the ECMAScript Language Specification.
### napi_is_detached_arraybuffer
<!-- YAML
added: v10.22.0
napiVersion: 7
-->

> Stability: 1 - Experimental

```C
napi_status napi_is_detached_arraybuffer(napi_env env,
napi_value arraybuffer,
Expand Down
6 changes: 3 additions & 3 deletions src/node_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// functions available in a new version of N-API that is not yet ported in all
// LTS versions, they can set NAPI_VERSION knowing that they have specifically
// depended on that version.
#define NAPI_VERSION 6
#define NAPI_VERSION 7
#endif
#endif

Expand Down Expand Up @@ -752,7 +752,7 @@ napi_get_all_property_names(napi_env env,

#endif // NAPI_VERSION >= 6

#ifdef NAPI_EXPERIMENTAL
#if NAPI_VERSION >= 7
// ArrayBuffer detaching
NAPI_EXTERN napi_status
napi_detach_arraybuffer(napi_env env,
Expand All @@ -762,7 +762,7 @@ NAPI_EXTERN napi_status
napi_is_detached_arraybuffer(napi_env env,
napi_value value,
bool* result);
#endif // NAPI_EXPERIMENTAL
#endif // NAPI_VERSION >= 7

EXTERN_C_END

Expand Down
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,6 @@

// The NAPI_VERSION provided by this version of the runtime. This is the version
// which the Node binary being built supports.
#define NAPI_VERSION 6
#define NAPI_VERSION 7

#endif // SRC_NODE_VERSION_H_
2 changes: 1 addition & 1 deletion test/addons-napi/test_general/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ assert.notStrictEqual(test_general.testGetPrototype(baseObject),

// test version management functions
// expected version is currently 4
assert.strictEqual(test_general.testGetVersion(), 6);
assert.strictEqual(test_general.testGetVersion(), 7);

const [ major, minor, patch, release ] = test_general.testGetNodeVersion();
assert.strictEqual(process.version.split('-')[0],
Expand Down
1 change: 0 additions & 1 deletion test/addons-napi/test_typedarray/test_typedarray.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#define NAPI_EXPERIMENTAL
#include <node_api.h>
#include <string.h>
#include "../common.h"
Expand Down

0 comments on commit 54c2bc2

Please sign in to comment.