Skip to content

Commit

Permalink
test: fix test-linux-perf flakiness
Browse files Browse the repository at this point in the history
The new V8 seems to be optimizing the functions we use in this test
faster than before. Increasing the sampling frequency for Linux perf
fixes the issue.

PR-URL: #27615
Refs: v8/v8@7.4.288.21...7.4.288.27
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
mmarchini authored and richardlau committed Oct 9, 2020
1 parent eee9412 commit 5170d14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/v8-updates/test-linux-perf.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (process.config.variables.node_shared)

const perfArgs = [
'record',
'-F500',
'-F999',
'-g',
'--',
process.execPath,
Expand Down

0 comments on commit 5170d14

Please sign in to comment.