Skip to content

Commit

Permalink
build: fix test-v8 target
Browse files Browse the repository at this point in the history
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in [1] to use ignored
files while generating `node-debug-support.cc`.

[1]: #14901

PR-URL: #17269
Fixes: nodejs/node-v8#26
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
targos authored and gibfahn committed Dec 20, 2017
1 parent 0605f01 commit 1802f3f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,7 @@ test-v8: v8
--no-presubmit \
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
$(TAP_V8)
git clean -fdxq -- deps/v8
@echo Testing hash seed
$(MAKE) test-hash-seed

Expand Down

0 comments on commit 1802f3f

Please sign in to comment.