Skip to content

Commit

Permalink
doc: remove vestigial onboarding section
Browse files Browse the repository at this point in the history
The onboarding-extras doc includes a section with a single bullet point
instructing the new Collaborator to write good pull request
descriptions. This material is likely superfluous and is in the wrong
document if it is not. (It more properly belongs in pull-requests.md as
it is information that is not specific to new Collaborators.) I am not
putting it in pullrequests.md because that document is already plenty
long and detailed, and includes advice on writing good commit messages,
which tend to become the pull request descriptions anyway.

PR-URL: #21028
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Jun 6, 2018
1 parent fd201e0 commit 09aec43
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions doc/onboarding-extras.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,3 @@ to update from nodejs/node:
* `git checkout master`
* `git remote update -p` OR `git fetch --all`
* `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)

## Best practices

* When making PRs, spend time writing a thorough description.

0 comments on commit 09aec43

Please sign in to comment.