Skip to content

Commit

Permalink
test: move some test from sequential to parallel
Browse files Browse the repository at this point in the history
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: #6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan BergstrΓΆm <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
  • Loading branch information
santigimeno authored and Myles Borins committed Apr 20, 2016
1 parent 3bb38b6 commit 089b855
Show file tree
Hide file tree
Showing 18 changed files with 13 additions and 4 deletions.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ child.on('exit', function(code, signal) {
assert.equal(code, 0);
assert.equal(output, 'hello, world!\n');
});

File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,3 @@ server.listen(common.PORT, function() {
process.on('exit', function() {
assert.ok(accepted);
});

13 changes: 13 additions & 0 deletions test/parallel/test-stdin-child-proc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
'use strict';
// This tests that pausing and resuming stdin does not hang and timeout
// when done in a child process. See test/parallel/test-stdin-pause-resume.js
const common = require('../common');
const assert = require('assert');
const child_process = require('child_process');
const path = require('path');
const cp = child_process.spawn(process.execPath,
[path.resolve(__dirname, 'test-stdin-pause-resume.js')]);

cp.on('exit', common.mustCall((code) => {
assert.equal(code, 0);
}));
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,3 @@ if (process.argv[2] === 'child') {
child.stdin.end();
}, 10);
}

File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,3 @@ process.on('exit', function() {
assert.ok(gotResponse);
assert.equal(0, resBodySize);
});

0 comments on commit 089b855

Please sign in to comment.