Skip to content

Commit

Permalink
deps: avoid compilation error with ASan
Browse files Browse the repository at this point in the history
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs/node#49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
targos authored and nodejs-github-bot committed Aug 16, 2024
1 parent 4047f8d commit ddbd7cc
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.2',
'v8_embedder_string': '-node.3',

##### V8 defaults for Node.js #####

Expand Down
24 changes: 12 additions & 12 deletions deps/v8/src/objects/object-macros.h
Original file line number Diff line number Diff line change
Expand Up @@ -696,24 +696,24 @@
#define WRITE_BARRIER(object, offset, value)
#define WRITE_BARRIER_CPP(object, offset, value)
#else
#define WRITE_BARRIER(object, offset, value) \
do { \
DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \
static_assert(kTaggedCanConvertToRawObjects); \
CombinedWriteBarrier(object, Tagged(object)->RawField(offset), value, \
UPDATE_WRITE_BARRIER); \
#define WRITE_BARRIER(object, offset, value) \
do { \
DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \
static_assert(kTaggedCanConvertToRawObjects); \
CombinedWriteBarrier(object, (object)->RawField(offset), value, \
UPDATE_WRITE_BARRIER); \
} while (false)
#endif

#ifdef V8_DISABLE_WRITE_BARRIERS
#define WEAK_WRITE_BARRIER(object, offset, value)
#else
#define WEAK_WRITE_BARRIER(object, offset, value) \
do { \
DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \
static_assert(kTaggedCanConvertToRawObjects); \
CombinedWriteBarrier(object, Tagged(object)->RawMaybeWeakField(offset), \
value, UPDATE_WRITE_BARRIER); \
#define WEAK_WRITE_BARRIER(object, offset, value) \
do { \
DCHECK_NOT_NULL(GetHeapFromWritableObject(object)); \
static_assert(kTaggedCanConvertToRawObjects); \
CombinedWriteBarrier(object, (object)->RawMaybeWeakField(offset), value, \
UPDATE_WRITE_BARRIER); \
} while (false)
#endif

Expand Down

0 comments on commit ddbd7cc

Please sign in to comment.