This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
doc: add explanations for querystring #9259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it can be used to decode `non-utf8` encoding string if necessary. | ||
| it can be used to decode a `non-utf8` encoding string if necessary. | ||
|
|
||
| `querystring.unescape` will try to use `decodeURIComponent` in the |
There was a problem hiding this comment.
I would not duplicate the description of querystring.unescape here, otherwise we'll have to update it twice every time it changes.
- add an article: `decode a non-utf8 string` - explain default behaviour of `querystring.unescape` - add a note that the baviour can change if other folks on your team have overridden it related to nodejs#9207 Conflicts: doc/api/querystring.markdown
robertkowalski
force-pushed
the
doc-querystring
branch
from
11d9efb
to
02b722e
Compare
|
@misterdjules done! |
|
LGTM. Thank you @robertkowalski and @h7lin! |
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Feb 25, 2015
In the documentation for querystring.parse, the documentation mentions that the default value for options.decodeURIComponent is the decodeURIComponent function, but it's actually the querystring.unescape function. PR-URL: nodejs#9259 Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Feb 25, 2015
- add an article: `decode a non-utf8 string` - explain default and fallback behaviour of `querystring.unescape` PR-URL: nodejs#9259 Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
|
@robertkowalski @h7lin Thank you! Landed in f1bf883 and 5d821fe. |
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 3, 2015
In the documentation for querystring.parse, the documentation mentions that the default value for options.decodeURIComponent is the decodeURIComponent function, but it's actually the querystring.unescape function. PR-URL: nodejs/node-v0.x-archive#9259 Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
robertkowalski
added a commit
to nodejs/node
that referenced
this pull request
Mar 3, 2015
- add an article: `decode a non-utf8 string` - explain default and fallback behaviour of `querystring.unescape` PR-URL: nodejs/node-v0.x-archive#9259 Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decode a non-utf8 stringquerystring.unescapeteam have overridden it
related to #9207