This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
tests: add test for cluster.worker.destroy(). #8307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| process.on('exit', function() { | ||
| assert.equal(workerExited, 2, | ||
| "When master exits, all workers should have exited too"); |
There was a problem hiding this comment.
For consistency, could you use single quotes in both of these asserts.
Add a simple test to cover workers' implementation of Worker.prototype.destroy(). Before adding this test, this code wouldn't be covered by the tests suite, and any regression introduced in workers' implementation of Worker.prototype.destroy wouldn't be caught. Fixes nodejs#8223.
misterdjules
force-pushed
the
fix-issue-8223
branch
from
42caac1
to
45bff12
Compare
|
@cjihrig Thanks, updated! |
|
Thanks. Slight modifications and landed in 9c992bd. |
|
@trevnorris Thank you! |
|
np. and thank you for the additional test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple test to cover workers' implementation of
Worker.prototype.destroy(). Before adding this test, this code wouldn't
be covered by the tests suite, and any regression introduced in workers'
implementation of Worker.prototype.destroy wouldn't be caught.
Fixes #8223.