Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

v8: cherry-pick JitCodeEvent patch from upstream #25589

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Original commit log follows:

Meaningful name for builtins in JitCodeEvent API.

Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline")
instead of labeling everything "Builtin:A builtin from the snapshot"

Review URL: https://codereview.chromium.org/1216833002

R=@sam-github?

Original commit log follows:

    Meaningful name for builtins in JitCodeEvent API.

    Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline")
    instead of labeling everything "Builtin:A builtin from the snapshot"

    Review URL: https://codereview.chromium.org/1216833002
@cjihrig
Copy link

cjihrig commented Jun 29, 2015

LGTM

@bnoordhuis
Copy link
Member Author

@cjihrig Can you land it (and maybe #25588 too, assuming it LGTY)? Sam is on PTO.

@cjihrig
Copy link

cjihrig commented Jun 29, 2015

@bnoordhuis sure

@cjihrig
Copy link

cjihrig commented Jun 29, 2015

misterdjules pushed a commit that referenced this pull request Jun 29, 2015
Original commit log follows:

    Meaningful name for builtins in JitCodeEvent API.

    Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline")
    instead of labeling everything "Builtin:A builtin from the snapshot"

    Review URL: https://codereview.chromium.org/1216833002

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #25589
@cjihrig
Copy link

cjihrig commented Jun 29, 2015

Thanks. Landed in 88a27a9.

@cjihrig cjihrig closed this Jun 29, 2015
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
Original commit log follows:

    Meaningful name for builtins in JitCodeEvent API.

    Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline")
    instead of labeling everything "Builtin:A builtin from the snapshot"

    Review URL: https://codereview.chromium.org/1216833002

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#25589
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants