This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
correct text #14352
Closed
correct text #14352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its -> it's -> it is a HTTP -> we read 'H' as 'eich' -> an HTTP
| @@ -24,7 +24,7 @@ all share server ports. | |||
| }); | |||
| } else { | |||
| // Workers can share any TCP connection | |||
| // In this case its a HTTP server | |||
| // In this case it is an HTTP server | |||
There was a problem hiding this comment.
@joyent/node-coreteam Could a native English speaker please confirm the usage of "an" instead of "a" here? Thank you!
There was a problem hiding this comment.
Confirmed per BBC:
Take the eighth letter of the alphabet, pronounce it haitch [...]
So "an HTTP" should be similar to "an hour". :)
|
Will land this in a separate commit and PR in http://github.com/nodejs/node master |
|
Closing here. New PR opened. |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#14352 originally submitted by @AlexKVal
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#14352 originally submitted by @AlexKVal Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: #2378
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Aug 26, 2015
per: nodejs/node-v0.x-archive#14352 originally submitted by @AlexKVal Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: #2378
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its -> it's -> it is
a HTTP -> we read 'H' as 'eich' -> an HTTP