unrefed interval timers not firing as expected in 0.10.34

[ploer]

It appears to me that after upgrading to 0.10.34, a setInterval() call that is unref()ed will only fire once and then not recur.

Example code:

var timer = setInterval(function() {
  console.log("timer fired");
}, 1000);

timer.unref();

console.log("Unrefed timer should fire every 1 second");

setTimeout(function() {
  console.log("Exiting after 5 seconds");
  process.exit();
}, 5000);

Output on 0.10.33, which is as expected, and 0.10.34, which only fires once and then doesn't recur:

ploer-macbook-4:timer_test ploer$ node --version
v0.10.33
ploer-macbook-4:timer_test ploer$ node timer_test.js 
Unrefed timer should fire every 1 second
timer fired
timer fired
timer fired
timer fired
Exiting after 5 seconds
ploer-macbook-4:timer_test ploer$ node --version
v0.10.34
ploer-macbook-4:timer_test ploer$ node timer_test.js 
Unrefed timer should fire every 1 second
timer fired
Exiting after 5 seconds
ploer-macbook-4:timer_test ploer$ 

Not sure if this is related to issue #8897, but the symptoms seem quite different, and although I've encountered both of them they were in different circumstances.

[ploer]

Just at a guess, in 0d05123, at timers.js:296:

+function unrefdHandle() {
+  this.owner._onTimeout();
+  if (!this.owner.repeat)
+    this.owner.close();
+}

Should that be this.owner._repeat?

[misterdjules]

Thank you @ploer for reporting the issue and looking into it. Indeed, the issue seems to be caused by 0d05123. @trevnorris could you please take a look?

[misterdjules]

@ploer We have a candidate for a fix with #8906, thank you very much for your help.

[ploer]

@misterdjules , thanks for the quick response & for all your contributions to node!

[misterdjules]

@ploer No problem, it's a team effort! Hopefully we'll be able to communicate soon when these fixes will be released.

[misterdjules]

@ploer Thanks again, landed in 78db74d.