Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

doc: fs docs should mention that mode is ignored when file exists #6847

Closed
bnoordhuis opened this issue Jan 12, 2014 · 3 comments
Closed

doc: fs docs should mention that mode is ignored when file exists #6847

bnoordhuis opened this issue Jan 12, 2014 · 3 comments
Assignees
@trevnorris
Labels
doc fs

Comments

@bnoordhuis
Copy link
Member

See subject.

On that topic, it's kind of odd that fs.createReadStream() accepts a mode argument. I guess it makes sense if you allow people to pass e.g. flags='w' but otherwise it's always a no-op.
@ghost ghost assigned trevnorris Jan 17, 2014
@trevnorris
Copy link

@bnoordhuis PR's welcome. ;-P

But seriously, have it on my list.

@nelsonpecora
Copy link

Looks like it's mentioned in the fs.open section. Is that acceptable?

jasnell added a commit to jasnell/node-joyent that referenced this issue Jun 24, 2015
@jasnell
doc: mention that mode is ignored if file exists
940978d 
per: nodejs#6847
jasnell added a commit that referenced this issue Jun 26, 2015
@jasnell
doc: mention that mode is ignored if file exists
1b027ee 
per: #6847

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25565
@jasnell
Copy link
Member

jasnell commented Jun 26, 2015

Landed in 1b027ee

@jasnell jasnell closed this as completed Jun 26, 2015
jasnell added a commit to jasnell/node-joyent that referenced this issue Jun 29, 2015
@jasnell
doc: mention that mode is ignored if file exists
0209501 
per: nodejs#6847

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#25565
jasnell added a commit that referenced this issue Aug 4, 2015
@jasnell
doc: mention that mode is ignored if file exists
418cde0 
per: #6847

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25591
jasnell added a commit to jasnell/node that referenced this issue Aug 4, 2015
@jasnell
doc: mention that mode is ignored if file exists
60b4239 
per: nodejs/node-v0.x-archive#6847

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs/node-v0.x-archive#25591
jBarz pushed a commit to ibmruntimes/node that referenced this issue Nov 4, 2016
@jasnell @jBarz
doc: mention that mode is ignored if file exists
2a26e83 
per: nodejs#6847

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#25591
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@trevnorris trevnorris

Labels
doc fs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bnoordhuis @trevnorris @jasnell @nelsonpecora