This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http: Avoid 'data'/'end' events after pause()
Fixes #1040.
- Loading branch information
Showing
2 changed files
with
121 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
// Copyright Joyent, Inc. and other Node contributors. | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a | ||
// copy of this software and associated documentation files (the | ||
// "Software"), to deal in the Software without restriction, including | ||
// without limitation the rights to use, copy, modify, merge, publish, | ||
// distribute, sublicense, and/or sell copies of the Software, and to permit | ||
// persons to whom the Software is furnished to do so, subject to the | ||
// following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included | ||
// in all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN | ||
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
// USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
||
var common = require('../common'); | ||
var assert = require('assert'); | ||
var http = require('http'); | ||
|
||
var expectedServer = 'Request Body from Client'; | ||
var resultServer = ''; | ||
var expectedClient = 'Response Body from Server'; | ||
var resultClient = ''; | ||
|
||
var server = http.createServer(function(req, res) { | ||
common.debug('pause server request'); | ||
req.pause(); | ||
setTimeout(function() { | ||
common.debug('resume server request'); | ||
req.resume(); | ||
req.setEncoding('utf8'); | ||
req.on('data', function(chunk) { | ||
resultServer += chunk; | ||
}); | ||
req.on('end', function() { | ||
common.debug(resultServer); | ||
res.writeHead(200); | ||
res.end(expectedClient); | ||
}); | ||
}, 100); | ||
}); | ||
|
||
server.listen(common.PORT, function() { | ||
var req = http.request({ | ||
port: common.PORT, | ||
path: '/', | ||
method: 'POST' | ||
}, function(res) { | ||
common.debug('pause client response'); | ||
res.pause(); | ||
setTimeout(function() { | ||
common.debug('resume client response'); | ||
res.resume(); | ||
res.on('data', function(chunk) { | ||
resultClient += chunk; | ||
}); | ||
res.on('end', function() { | ||
common.debug(resultClient); | ||
server.close(); | ||
}); | ||
}, 100); | ||
}); | ||
req.end(expectedServer); | ||
}); | ||
|
||
process.on('exit', function() { | ||
assert.equal(expectedServer, resultServer); | ||
assert.equal(expectedClient, resultClient); | ||
}); |
e6b6075
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love that this is in, and I'm not complaining, but....
This really needs to be fixed in Stream.pipe() as well.
The fact that we insure this for http.ServerRequest and nowhere else is not good.
We also need to get pause() to take a size argument for how large it should allow the buffer to get before it causes the remote end to stop sending data. This has all been discussed and more or less approved in pull requests that weren't finished.
It would be great if, for 0.8, we could get Stream.pause(size) implemented/fixed and make it consistent across all of node.
e6b6075
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to be in on discussions about the Stream api. I've talked to @mikeal about a few ideas I have, but I'm not up to speed on a lot of internal discussion you guys have had. I agree that this shouldn't be specific to fd backed streams if possible.
e6b6075
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@polotek: See #1681. Might be worth raising on nodejs-dev as well.