Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
[ISSUE #2554 #2567] throw if fs args for 'start' or 'end' are strings
Browse files Browse the repository at this point in the history
  • Loading branch information
AJ ONeal authored and isaacs committed Feb 27, 2012
1 parent 483edbd commit 7f58d20
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
8 changes: 8 additions & 0 deletions lib/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -1038,8 +1038,13 @@ var ReadStream = fs.ReadStream = function(path, options) {
if (this.encoding) this.setEncoding(this.encoding);

if (this.start !== undefined) {
if ('number' !== typeof this.start) {
throw TypeError('start must be a Number');
}
if (this.end === undefined) {
this.end = Infinity;
} else if ('number' !== typeof this.end) {
throw TypeError('end must be a Number');
}

if (this.start > this.end) {
Expand Down Expand Up @@ -1226,6 +1231,9 @@ var WriteStream = fs.WriteStream = function(path, options) {
}

if (this.start !== undefined) {
if ('number' !== typeof this.start) {
throw TypeError('start must be a Number');
}
if (this.start < 0) {
throw new Error('start must be >= zero');
}
Expand Down
24 changes: 24 additions & 0 deletions test/simple/test-fs-non-number-arguments-throw.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
var assert = require('assert'),
fs = require('fs'),
saneEmitter,
sanity = 'ire(\'assert\')';

saneEmitter = fs.createReadStream(__filename, { start: 17, end: 29 });

assert.throws(function () {
fs.createReadStream(__filename, { start: "17", end: 29 });
}, "start as string didn't throw an error for createReadStream");

assert.throws(function () {
fs.createReadStream(__filename, { start: 17, end: "29" });
}, "end as string didn't throw an error");

assert.throws(function () {
fs.createWriteStream(__filename, { start: "17" });
}, "start as string didn't throw an error for createWriteStream");

saneEmitter.on('data', function (data) {
// a sanity check when using numbers instead of strings
assert.strictEqual(sanity, data.toString('utf8'), 'read ' +
data.toString('utf8') + ' instead of ' + sanity);
});

0 comments on commit 7f58d20

Please sign in to comment.