This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
net,dgram: workers can listen on exclusive ports
Allow cluster workers to listen on exclusive ports for TCP and UDP, instead of forcing all calls to go through the cluster master. Fixes: #3856 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com>
- Loading branch information
1 parent
9b8837b
commit 029cfc1
Showing
6 changed files
with
232 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // Copyright Joyent, Inc. and other Node contributors. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a | ||
| // copy of this software and associated documentation files (the | ||
| // "Software"), to deal in the Software without restriction, including | ||
| // without limitation the rights to use, copy, modify, merge, publish, | ||
| // distribute, sublicense, and/or sell copies of the Software, and to permit | ||
| // persons to whom the Software is furnished to do so, subject to the | ||
| // following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included | ||
| // in all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
| // OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
| // MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN | ||
| // NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| // USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| var common = require('../common'); | ||
| var assert = require('assert'); | ||
| var cluster = require('cluster'); | ||
| var dgram = require('dgram'); | ||
|
|
||
| function noop() {} | ||
|
|
||
| if (cluster.isMaster) { | ||
| var worker1 = cluster.fork(); | ||
|
|
||
| worker1.on('message', function(msg) { | ||
| assert.equal(msg, 'success'); | ||
| var worker2 = cluster.fork(); | ||
|
|
||
| worker2.on('message', function(msg) { | ||
| assert.equal(msg, 'socket2:EADDRINUSE'); | ||
| worker1.kill(); | ||
| worker2.kill(); | ||
| }); | ||
| }); | ||
| } else { | ||
| var socket1 = dgram.createSocket('udp4', noop); | ||
| var socket2 = dgram.createSocket('udp4', noop); | ||
|
|
||
| socket1.on('error', function(err) { | ||
| // no errors expected | ||
| process.send('socket1:' + err.code); | ||
| }); | ||
|
|
||
| socket2.on('error', function(err) { | ||
| // an error is expected on the second worker | ||
| process.send('socket2:' + err.code); | ||
| }); | ||
|
|
||
| socket1.bind({ | ||
| address: 'localhost', | ||
| port: common.PORT, | ||
| exclusive: false | ||
| }, function() { | ||
| socket2.bind({port: common.PORT + 1, exclusive: true}, function() { | ||
| // the first worker should succeed | ||
| process.send('success'); | ||
| }); | ||
| }); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // Copyright Joyent, Inc. and other Node contributors. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a | ||
| // copy of this software and associated documentation files (the | ||
| // "Software"), to deal in the Software without restriction, including | ||
| // without limitation the rights to use, copy, modify, merge, publish, | ||
| // distribute, sublicense, and/or sell copies of the Software, and to permit | ||
| // persons to whom the Software is furnished to do so, subject to the | ||
| // following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included | ||
| // in all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
| // OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
| // MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN | ||
| // NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| // USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| var common = require('../common'); | ||
| var assert = require('assert'); | ||
| var cluster = require('cluster'); | ||
| var net = require('net'); | ||
|
|
||
| function noop() {} | ||
|
|
||
| if (cluster.isMaster) { | ||
| var worker1 = cluster.fork(); | ||
|
|
||
| worker1.on('message', function(msg) { | ||
| assert.equal(msg, 'success'); | ||
| var worker2 = cluster.fork(); | ||
|
|
||
| worker2.on('message', function(msg) { | ||
| assert.equal(msg, 'server2:EADDRINUSE'); | ||
| worker1.kill(); | ||
| worker2.kill(); | ||
| }); | ||
| }); | ||
| } else { | ||
| var server1 = net.createServer(noop); | ||
| var server2 = net.createServer(noop); | ||
|
|
||
| server1.on('error', function(err) { | ||
| // no errors expected | ||
| process.send('server1:' + err.code); | ||
| }); | ||
|
|
||
| server2.on('error', function(err) { | ||
| // an error is expected on the second worker | ||
| process.send('server2:' + err.code); | ||
| }); | ||
|
|
||
| server1.listen({ | ||
| host: 'localhost', | ||
| port: common.PORT, | ||
| exclusive: false | ||
| }, function() { | ||
| server2.listen({port: common.PORT + 1, exclusive: true}, function() { | ||
| // the first worker should succeed | ||
| process.send('success'); | ||
| }); | ||
| }); | ||
| } |
029cfc1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🚢 🍻
029cfc1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
029cfc1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome !