Prefer --inspect-brk over --debug-brk

[ofrobots]

Node 8.x no longer has --debug-brk and --inspect-brk is backwards
compatible with Node 7.

Ref: nodejs/node#12197.

I will be cherry-picking this on nodejs/node#11441.

[jkrems]

If we make this change, should this just be --inspect-brk=${inspectPort}?

P.S.: What I mean is that we don't need to pass --inspect anymore.

[ofrobots]

Ack.

[jkrems]

Just looked it up: This will drop support for node <7.6.0. Will publish as major for the release to npm.

[ofrobots]

Is it possible to take a dependency on semver for this module? If not, I can use regexes to avoid the major due to <7.6.0.

[jkrems]

I would prefer delaying the pain of getting 3rd party modules working in our bundled build (where we get away with just dumping the files into node right now). So 👍 for a regex solution even though it's not "perfectly clean".

[ofrobots]

Done. PTAL.

[jkrems]

🎉

[jkrems]

Passes locally, CI: https://ci.nodejs.org/job/node-inspect-continuous-integration/34/

[jkrems]

That OSX failure looks scary but I'd blame the latest nightly rather than this change:

node::FatalException(v8::Isolate*, v8::Local<v8::Value>, v8::Local<v8::Message>) [/Users/iojs/build/workspace/node-inspect-continuous-integration/MACHINE/osx1010/node-v8.0.0-nightly20170405491d59da84-darwin-x64/bin/node]
3:  < v8::V8::ToLocalEmpty() [/Users/iojs/build/workspace/node-inspect-continuous-integration/MACHINE/osx1010/node-v8.0.0-nightly20170405491d59da84-darwin-x64/bin/node]
4: node::inspector::AgentImpl::CallAndPauseOnStart(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/iojs/build/workspace/node-inspect-continuous-integration/MACHINE/osx1010/node-v8.0.0-nightly20170405491d59da84-darwin-x64/bin/node]
5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/Users/iojs/build/workspace/node-inspect-continuous-integration/MACHINE/osx1010/node-v8.0.0-nightly20170405491d59da84-darwin-x64/bin/node]
6: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/iojs/build/workspace/node-inspect-continuous-integration/MACHINE/osx1010/node-v8.0.0-nightly20170405491d59da84-darwin-x64/bin/node]
7:  < v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/iojs/build/workspace/node-inspect-continuous-integration/MACHINE/osx1010/node-v8.0.0-nightly20170405491d59da84-darwin-x64/bin/node]