Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop with zero-length options. #745

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Fix infinite loop with zero-length options. #745

merged 1 commit into from
Sep 25, 2015

Commits on Sep 25, 2015

  1. Fix infinite loop with zero-length options. 

    The bundled copy of GYP enters an infinite loop when it encounters a
zero-length option so ensure those don't get through.

The root cause is a bad guard in gyp/pylib/gyp/input.py that doesn't
take into account that `'' in 'whatever'` evaluates to True.

Upstream fix at https://codereview.chromium.org/1364373004/.

Fixes: #744
PR-URL: #745
Reviewed-By: Nathan Rajlich <nathan@tootallnate.net>
    @bnoordhuis
    bnoordhuis committed Sep 25, 2015
    Configuration menu
    Copy the full SHA
    2ac7de0 View commit details
    Browse the repository at this point in the history