test: fix Python unittests #1961
Conversation
cclauss
requested review from
joaocgreis,
bnoordhuis,
addaleax,
gengjiawen and
richardlau
|
@joaocgreis Can you please take a look at the failing Windows tests? A fix did not jump out at me. |
| @@ -1085,6 +1085,7 @@ def testConvertToMSBuildSettings_full_synthetic(self): | |||
| 'GenerateManifest': 'true', | |||
| 'IgnoreImportLibrary': 'true', | |||
| 'LinkIncremental': 'false'}} | |||
| self.maxDiff = 9999 # on failure display a long diff | |||
There was a problem hiding this comment.
self.maxDiff = None if you don't really want an upper limit?
There was a problem hiding this comment.
Understood. These are reasonable limits for these test results.
I think part of the issue is that Travis has Visual Studio 2017 on Windows and the version of |
|
@cclauss pushed a fix for the issues on Windows.
|
|
Travis had failed on my repo earlier, but passed on a new run. Possibly some caching issue or something that got fixed. I guess this is good then! |
PR-URL: #1961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #1961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: João Reis <reis@janeasystems.com>
Add pytest to our Travis CI jobs to run 27 Python tests.
Checklist
npm install && npm testpassesDescription of change