Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite install loop. #1384

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fix infinite install loop. #1384

merged 1 commit into from
Feb 27, 2018

Commits on Feb 27, 2018

  1. Fix infinite install loop. 

    Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: `$HOME/.node-gyp`) and
the current working directory aren't writable.  Users won't often hit
that except through `sudo npm install` because npm drops privileges
before executing node-gyp.

Fixes: #1383
PR-URL: #1384
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @bnoordhuis
    bnoordhuis committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    8b7ccfe View commit details
    Browse the repository at this point in the history