Skip to content

Commit

Permalink
gyp: fix undefined name: cflags --> ldflags
Browse files Browse the repository at this point in the history
The current code would raise NameError at runtime.

PR-URL: #1901
Reviewed-By: Rod Vagg <rod@vagg.org>
  • Loading branch information
cclauss authored and rvagg committed Oct 2, 2019
1 parent 5871dcf commit 53ee7df
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gyp/pylib/gyp/xcode_emulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,7 @@ def GetLdflags(self, configname, product_dir, gyp_to_build_path, arch=None):
if self._IsXCTest():
platform_root = self._XcodePlatformPath(configname)
if platform_root:
cflags.append('-F' + platform_root + '/Developer/Library/Frameworks/') # noqa TODO @cclauss
ldflags.append('-F' + platform_root + '/Developer/Library/Frameworks/')

is_extension = self._IsIosAppExtension() or self._IsIosWatchKitExtension()
if sdk_root and is_extension:
Expand Down

0 comments on commit 53ee7df

Please sign in to comment.