Skip to content
This repository has been archived by the owner on Jul 31, 2018. It is now read-only.

Commit

Permalink
Invert dependency between core and readable-stream
Browse files Browse the repository at this point in the history
  • Loading branch information
mcollina committed Jan 24, 2017
1 parent 735b776 commit 0445eb2
Showing 1 changed file with 52 additions and 0 deletions.
52 changes: 52 additions & 0 deletions 00X-streams.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
| Title | Invert dependency of readable-stream |
|--------|--------------------------------------|
| Author | @mcollina |
| Status | DRAFT |
| Date | 2017-01-12 12:00:00 |

## Description

The `readable-stream` module is one of the most popular modules on NPM,
with 33 million download per month. `readable-stream` is the basis of
most of the ecosystem utilities for manipulating streams, as it provides
a consistent API across all the different versions of Node.js and the
browser: from Node.js v0.8, and IE 9 and Safari 5 as the oldest browsers.

`readable-stream` is an export of the latest stream API from the Node.js,
done via a mixture of babel transpiling and regular expressions. The export
means that `readable-stream` has to follow the Node.js release cycle, and it
is not versioned independently. Specifically, versioning of `readable-stream`
is extremely hard, as *we are currently not bumping major*
to avoid breaking many packages and maintaining multiple lines. The current
situation is not ideal, as `readable-stream` passively follows what is merged
in Node.js.

At the moment `readable-stream` does not have its own documentation, it is the
documentation of whichever version of Node.js is built from. This creates confusion,
as the latest `stream` from Node.js supports some features that cannot be ported
to all versions of Node.js.

This EP proposes to invert that dependency, and have Node.js include
readable-stream from the `deps` folder.

## Process / Timeline

1. move the code of streams into `readable-stream`
2. amend the build script for the NPM/ecosystem build
3. rewrite the tests to easily check against both the node
source folder and old versions of Node.js and the browser.
4. merge back all changes that happened in the meanwhile, and sync up
5. add `nodejs/readable-stream` inside deps of Node.js, and remove the streams implementation
6. bump *minor* version of `readable-stream`

## Challenges

1. export git history from node.js
2. handling issues between the two repositories
3. docs

These challenges needs to be adressed with the rest of the node collaborators.

## Target version of Node

We think we should target this to be shipped in Node 8.

0 comments on commit 0445eb2

Please sign in to comment.