Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare ncu for new README format #561

Merged
merged 2 commits into from
Sep 20, 2021
Merged

feat: prepare ncu for new README format #561

merged 2 commits into from
Sep 20, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 17, 2021

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #561 (3dc0d62) into main (e9bb948) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files          35       35           
  Lines        1750     1750           
=======================================
  Hits         1445     1445           
  Misses        305      305           
Impacted Files Coverage Δ
lib/collaborators.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9bb948...3dc0d62. Read the comment docs.

@@ -6,7 +6,8 @@ const TSC_TITLE = '### TSC (Technical Steering Committee)';
const TSCE_TITLE = '### TSC Emeriti';
const CL_TITLE = '### Collaborators';
const CLE_TITLE = '### Collaborator Emeriti';
const CONTACT_RE = /\* +\[(.+?)\]\(.+?\) +-\s\*\*(.+?)\*\* +&lt;(.+?)&gt;/mg;
const CONTACT_RE =
/\* +\[(.+?)\]\(.+?\) +-\s\*\*(.+?)\*\* +(?:&lt;|<)(.+?)(?:&gt;|>)/mg;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need to include the backslash in the regexp?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, we clearly don't, because the tests pass, but I don't understand how it works ^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand which backslash you are talking about?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one you had to add in the readme to escape <

Copy link
Member Author

@Trott Trott Sep 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, it doesn't work. I thought I ran it against the main branch, but I guess I didn't. The change in the README doesn't cause a test failure there. I'm guessing it's using the contact info from the TSC entry for the same user.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @targos. Fixed.

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137
@Trott
Copy link
Member Author

Trott commented Sep 19, 2021

Do we know why the 16.x GitHub Action is failing on a seemingly-unrelated test?

@targos
Copy link
Member

targos commented Sep 19, 2021

The tests are a bit flaky on Windows

@Trott
Copy link
Member Author

Trott commented Sep 19, 2021

The tests are a bit flaky on Windows

OK, I'll re-run it. Thanks.

@Trott Trott merged commit 6898338 into nodejs:main Sep 20, 2021
@Trott Trott deleted the readme branch September 20, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants