build: add win32 convenience build rule #44
Conversation
Update the repository README file to accurately reflect the intent and nature of this repository. The original io.js README is preserved as iojs_README.md. This is temporary just while the convergence process gets underway. Once the repository moves over to the official organization, this can be reverted back to an actual project README that accurately reflects the combined projects. Reviewed-By: @jasnell James M Snell <jasnell@gmail.com> Reviewed-By: @Fishrock123 Jeremiah Senkpiel PR-URL: nodejs#4
Per: nodejs/node#27 See: nodejs/node#27 (comment) ORIGINAL-PR: nodejs/node-v0.x-archive#9085 PORT-FROM: nodejs/node-v0.x-archive@6168fe6 /cc: @misterdjules
|
not sure about the status of also @jasnell, it'd be helpful to /cc @nodejs/build on all changes related to configure, Makefile and vcbuild.bat cause there's lots of context around those bits |
|
Is |
|
FWIW, this gives a bit of context around this change: nodejs/node#528. |
|
@misterdjules We've re-enabled snapshots in io.js by recommendation from the v8 team since existing insecurities had been resolved. |
|
Besides V8 snapshots, the point of having a That makes these jobs' maintenance easier: instead of modifying every Jenkins job, we just change what gets enabled when running If io.js doesn't have that, then I think it's a good thing to add. |
|
Agreed, we currently put too much logic into jenkins and we need to shift it back into vcbuild.bat and Makefile so I'm happy with this direction. The only question is about nosnapshot. |
Again, if it disables v8 snapshots, it shouldn't be there anymore. :P |
Fishrock123
force-pushed
the
master
branch
2 times, most recently
from
a71ee93
to
e11fe0c
Compare
|
cc @nodejs/build |
|
perhaps this should go in to io.js as well? |
|
connects a little with changes in nodejs/node#1938 |
|
So uh, what's the status of this then? |
|
As others have already pointed out, nosnapshot=1 sound not be set. Other than that, +1 for the vcbuild.bat change. |
Per: nodejs/node#27
See: nodejs/node#27 (comment)
ORIGINAL-PR: nodejs/node-v0.x-archive#9085
PORT-FROM: nodejs/node-v0.x-archive@6168fe6
/cc: @misterdjules