Next

[kkoopa]

Start collecting pull requests for NAN 2 here.

[bnoordhuis]

LGTM although the CI seems (partially) unhappy.

Out of curiosity, why was NanNewContextHandle deprecated?

[kkoopa]

AppVeyor hasn't pulled in build images for io.js 2 yet, they have it scheduled
for today, so it should start working by itself soon enough.

NanNewContextHandle was replaced with NanNew.
On Friday 08 May 2015 03:14:21 Ben Noordhuis wrote:

LGTM although the CI seems (partially) unhappy.

Out of curiosity, why was NanNewContextHandle deprecated?

---

Reply to this email directly or view it on GitHub:
#334 (comment)

[kkoopa]

Only things missing now are:

• the new Buffer implementation
• sticking everything (but macros) in namespace Nan
• replacement of some NanNew<String> routines that should not be

[kkoopa]

Don't know why appveyor lists a failure although nothing failed. Can't reproduce.

[kkoopa]

Probably fixed it now. It was due to a sort of broken test (more like broken io.js). Calling gc() is supposed to be synchronous, but it does not appear to be so really. Made a polling loop to circumvent it.

[kkoopa]

A whole lot of documentation will need to be written and rewritten. Should we make use of Doxygen or some other similar alternative?

It would be nice to have proper documentation that did not require too much prerequisite API knowledge. In the past, this was less of a problem, as NAN was mostly used to port existing addons, but now almost all of them use NAN and the docs are more important for new developments.

Should NAN be documented the same way a core module would be documented, to fit in with other node docs?

P.S. I don't like writing documentation.

[agnat]

I'm not a big fan of doxygen. It is either in the way or annoyingly uninformative. Sometimes both. I'd rather help with writing proper documentation. IMO it is the only way to describe things like NanNew<>() for the average reader.

P.S. I don't either ... but then who does?

[kkoopa]

I'm not that big a fan of Doxygen myself either. I like reading its output, but don't like seeing it in the code or writing it. The reason I thought about it is because many classes are almost directly derived from V8. Please do help out with writing proper documentation, I have so many things to do that documentation gets rather low priority, even though I know that documentation is important for the end-user.

[kkoopa]

Merged. 2.0.0 Is out.

@rvagg Nothing should block io.js 3.0 anymore.

[rvagg]

Woohoo! Thanks @kkoopa, I'm working on release notes for v3 now. Should be out soon.