Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add anonrig to build #3466

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 21, 2023

After talking to several TSC members, I'm opening this self-nomination pull request:

I am interested in joining the Build WG to help with the current effort of understanding the infrastructure that's causing issues with our current setup. I'm also interested in getting familiar with our CI and solving outages and help improving them.

cc @MoLow @richardlau

@MoLow
Copy link
Member

MoLow commented Aug 21, 2023

+1 from me

@UlisesGascon
Copy link
Member

Big +1 from me.

@mhdawson
Copy link
Member

+1 from me

@Trott
Copy link
Member

Trott commented Sep 7, 2023

@nodejs/build Is there anything that @anonrig or someone else should do to get this moving forward? Does anything need to happen before onboarding can begin?

@MoLow
Copy link
Member

MoLow commented Sep 9, 2023

I think we can continue with onboarding (some other issues on build-agenda can probably also be handled since its been a long time since last meeting)

@anonrig
Copy link
Member Author

anonrig commented Sep 10, 2023

Hey @MoLow, would you mind starting the onboarding to get the ball rolling?

@mhdawson
Copy link
Member

@MoLow if possible I'd like to be in the onboarding session when you do it with @anonrig

@MoLow
Copy link
Member

MoLow commented Sep 12, 2023

I don't think I have all the context yet to perform an onboarding, so definitely someone else would need to leed it

@UlisesGascon
Copy link
Member

I don't think I have all the context yet to perform an onboarding, so definitely someone else would need to leed it

I can lead it, no problem at all. I can include you also @mhdawson 👍.

@UlisesGascon
Copy link
Member

UlisesGascon commented Oct 19, 2023

Onboarding to build-test issue checklist

  • Email the new member and obtain their public GPG key
  • Add them to the test group in nodejs-private/secrets
  • Add them to the nodejs/build and nodejs-private/build GitHub teams
  • Before the meeting the Onboardee is to:
  • Schedule a meeting with the member to:
    • Walk them through the infrastructure and what other members do
    • Explain how to decrypt nodejs/secrets
    • Practice running the jenkins/worker/create.yml playbook on one of the machines in the test CI cluster
    • Answer any questions they may have
  • PR changes to README.md to add the member to build-test

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@UlisesGascon UlisesGascon merged commit 68242d7 into nodejs:main Oct 19, 2023
1 check passed
@anonrig anonrig deleted the self-nomination branch October 19, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants