Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: add ubuntu1404-ppc64_le-4 to inventory #1739

Merged
merged 1 commit into from
Apr 11, 2019
Merged

ansible: add ubuntu1404-ppc64_le-4 to inventory #1739

merged 1 commit into from
Apr 11, 2019

Conversation

sam-github
Copy link
Contributor

@sam-github
Copy link
Contributor Author

@mhdawson Should -3 be removed? It sounds like its broken or gone?

@sam-github sam-github mentioned this pull request Mar 22, 2019
Merged
mhdawson
mhdawson approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

We should remove -3 as well. Landing this and you can do that as a follow on PR.

@mhdawson mhdawson merged commit 5e4ad40 into nodejs:master Apr 11, 2019
@sam-github sam-github mentioned this pull request Apr 11, 2019
Merged
refack pushed a commit that referenced this pull request Apr 11, 2019
@sam-github @refack
ansible: remove non-existent ubuntu1404-ppc64_le-3 (#1758)
e10a446 
See: #1739 (comment)

PR-URL: #1739
Reviewed-By: Refael Ackermann <refack@gmail.com>
@sam-github sam-github deleted the add-ppc-le-4 branch April 11, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sam-github @mhdawson