Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor inconsistency in tarball name vs untarred name for 32 bit package #45

Closed
springmeyer opened this issue Feb 11, 2015 · 4 comments
Closed

Comments

@springmeyer
Copy link

I noticed that https://iojs.org/download/release/v1.1.0/iojs-v1.1.0-linux-x86.tar.gz unpacks as /iojs-v1.1.0-linux-ia32 instead of iojs-v1.1.0-linux-x86. Ideally this would be consistent with node which uses x86 for the directory inside the tarball.

@rmg
Copy link

rmg commented Feb 16, 2015

I took a quick (as in 15 minutes of git grep and head scratching) look at the build scripts and couldn't see any places in iojs itself where the tarball name isn't derived from the directory name.

@rvagg could this is happening in an upload script?

@rvagg
Copy link
Member

rvagg commented Feb 16, 2015

yes, it's done at upload time to keep the names consistent in /dist/:

farch=$ARCH
[[ $farch == 'ia32' ]] && farch='x86'
ssh iojs-www "mkdir -p staging/release/${version}"
scp -p iojs-${version}-linux-${ARCH}.tar.gz iojs-www:staging/release/${version}/iojs-${version}-linux-${farch}.tar.gz
scp -p iojs-${version}-linux-${ARCH}.tar.xz iojs-www:staging/release/${version}/iojs-${version}-linux-${farch}.tar.xz
ssh iojs-www "touch staging/release/${version}/iojs-${version}-linux-${farch}.tar.gz.done staging/release/${version}/iojs-${version}-linux-${farch}.tar.xz.done"

prior to this the build is done with:

make -j$JOBS binary DESTCPU=$DESTCPU ARCH=$ARCH

it's ARCH that needs changing on those machines

@jbergstroem
Copy link
Member

Not a bug. @rvagg?

@rvagg
Copy link
Member

rvagg commented Nov 30, 2015

was a bug, fixed now afaik

@rvagg rvagg closed this as completed Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants