Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Foundation Calendar info +formatting updates #17

Closed
wants to merge 5 commits into from
Closed

Added Foundation Calendar info +formatting updates #17

wants to merge 5 commits into from

Conversation

williamkapke
Copy link
Contributor

Also updated:

  • corrected my github handle
  • sorted "contacts" A-Z
  • normalized handle display

@williamkapke
Added Foundation Calendar info +formatting updates
a10404c 
Also updated:
- corrected my github handle
- sorted "contacts" A-Z
- normalized handle display
@williamkapke williamkapke mentioned this pull request Oct 8, 2017
Closed
targos

This comment was marked as off-topic.

Sign in to view

@Trott
Copy link
Member

Trott commented Oct 9, 2017

Not a blocker, but I would recommend sorting names on GitHub handle rather than name. The reason is that the GitHub handle will be a limited number of easy-to-sort characters. If you sort on name, you may find yourself required to figure out where Сковорода Никита Андреевич or 顾天骋 goes in the list.

@williamkapke
Copy link
Contributor Author

Good call @Trott. You're very wise. Updated.

jasnell

This comment was marked as off-topic.

Sign in to view

gibfahn

This comment was marked as off-topic.

Sign in to view

gibfahn

This comment was marked as off-topic.

Sign in to view

bnb

This comment was marked as off-topic.

Sign in to view

mhdawson

This comment was marked as off-topic.

Sign in to view

mhdawson pushed a commit that referenced this pull request Oct 11, 2017
@williamkapke @mhdawson
Added Foundation Calendar info +formatting updates
0019781 
Also updated:
- corrected my github handle
- sorted "contacts" A-Z
- normalized handle display

PR-URL: #17
Reviewed-By: MichaëZasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@mhdawson
Copy link
Member

Landed as 0019781

@mhdawson mhdawson closed this Oct 11, 2017
@targos targos deleted the calendar branch March 18, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@bnb bnb bnb approved these changes

@targos targos targos approved these changes

@mhdawson mhdawson mhdawson approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@williamkapke @Trott @mhdawson @jasnell @bnb @targos @gibfahn