fix: allow ":" character in digestAuth password

[kulpsin]

str.split() -function would cut rest of the password off when encountering a ":" character.

Old:

let s = 'user:passwordwith:character';
const [user, pass] = userpass.split(':');
console.log(`User '${user}' and pass '${pass}'`);

Output: User 'user' and pass 'passwordwith'

Fixed:

const user = userpass.split(':', 1);
const pass = userpass.slice(user[0].length+1);
console.log(`User '${user}' and pass '${pass}'

Output: User 'user' and pass 'passwordwith:character'

Summary by CodeRabbit

• Bug Fixes

  • Improved the extraction process for username and password from the userpass string, enhancing clarity and maintainability.

• Refactor

  • Refined the logic within the digest authentication header function for better readability without altering its overall functionality.

[coderabbitai]

Walkthrough

The changes involve a modification to the digestAuthHeader function in the src/utils.ts file. The method of extracting the user and pass from the userpass string has been updated to a two-step process using indexOf and substring. This alteration clarifies the extraction logic while maintaining the overall function's behavior.

Changes

Files	Change Summary
src/utils.ts	Modified the digestAuthHeader function to change how user and pass are derived from userpass.

Poem

🐇 In the code where functions dwell,
A change was made, oh what a spell!
User and pass, now clear as day,
Extracted with care, in a smarter way.
Hopping through logic, bright and neat,
Our code’s a garden, a lovely treat! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c80e147 and efd9c4d.

Files selected for processing (1)

• src/utils.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/utils.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

Open in Stackblitz

yarn add https://pkg.pr.new/node-modules/urllib@532.tgz

commit: efd9c4d