Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Remove dependency on streams polyfill #149

Merged
merged 6 commits into from
May 18, 2023

Conversation

jimmywarting
Copy link
Contributor

The purpose of this PR is:

  • To remove the dependency on web streams polyfill
  • Update LTS supported NodeJS version as to use web streams directly from NodeJS instead
  • bump engines.node to >=16.7 (16.5 received web streams... 16.7 got buffer.Blob.stream() included)
  • remove CHANGELOG.md and instead start using github releases to craft new changes based on merged PRs

  • I prefixed the PR-title with docs: , fix(area): , feat(area): or breaking(area):
  • I updated the README.md
  • I Added unit test(s)

@jimmywarting jimmywarting requested review from gr2m and LinusU May 14, 2023 01:14
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@57e4dae). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage        ?   93.67%           
=======================================
  Files           ?        3           
  Lines           ?      458           
  Branches        ?       95           
=======================================
  Hits            ?      429           
  Misses          ?       29           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jimmywarting
Copy link
Contributor Author

ping @LinusU

@gr2m
Copy link

gr2m commented May 16, 2023

How are releases created?

@jimmywarting
Copy link
Contributor Author

jimmywarting commented May 16, 2023

there is no automated flow in this repo.
everything is done manually atm

@jimmywarting jimmywarting merged commit a1a182e into node-fetch:main May 18, 2023
@jimmywarting jimmywarting deleted the new-lts branch May 18, 2023 11:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to remove web-streams-polyfill dependency?
2 participants