Skip to content

Commit

Permalink
fix hasOwnProperty usage
Browse files Browse the repository at this point in the history
  • Loading branch information
dead-horse committed Dec 27, 2013
1 parent 3173524 commit 2579e90
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions lib/module.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ var _nativeNames = [
'url',
];

// See: https://github.com/joyent/node/issues/1707#issuecomment-2106309
function hasOwnProperty(obj, prop) {
return Object.prototype.hasOwnProperty.call(obj, prop);
}

function initConfig() {
_cacheModules = {};
_disableModules = {};
Expand Down Expand Up @@ -84,13 +89,13 @@ exports._findPath = Module._findPath;

exports._resolveFilename = function (request, parent) {
debug('SandboxModule._resolveFilename %s parent: %s', request, parent && parent.id);
if (_disableModules.hasOwnProperty(request)) {
if (hasOwnProperty(_disableModules, request)) {
var err = new Error("Disable module '" + request + "'");
err.code = 'MODULE_DISABLE';
throw err;
}

if (_nativeModules.hasOwnProperty(request)) {
if (hasOwnProperty(_nativeModules, request)) {
return request;
}

Expand Down Expand Up @@ -134,7 +139,7 @@ exports._load = function (request, parent, isMain) {
var filename = exports._resolveFilename(request, parent);

// check native modules first
if (_nativeModules.hasOwnProperty(filename)) {
if (hasOwnProperty(_nativeModules, filename)) {
debug('SandboxModule._load native module %s', request);
return _nativeModules[filename];
}
Expand Down

0 comments on commit 2579e90

Please sign in to comment.